XEP-0469: Bookmark pinning - #4088
Open
jcbrand wants to merge 4 commits into
Open
Conversation
mercihabam
reviewed
Jun 19, 2026
mercihabam
left a comment
mercihabam
left a comment
Contributor
There was a problem hiding this comment.
Thank you @jcbrand for fine-tuning this further. I can't wait to see it in the next release.
jcbrand
force-pushed
the
bookmark-pinning
branch
2 times, most recently
from
June 21, 2026 20:30
9bf3191 to
e90eeb0
Compare
…ned state Review fixes on top of the XEP-0469 pinning implementation: - Establish the bookmark<->MUC link whenever either side appears: on bookmark-add, on chatbox-add, and via a one-off sweep after bookmarks are fetched. - Derive `pinned` from the bookmark's `<pinned/>` extension (single source of truth) instead of storing a separate cached boolean. - Simplify pinBookmark/unpinBookmark to only mutate extensions and return the promise; drop the unreachable try/catch rollback around the async api.bookmarks.set call. - Make `setBookmark` idempotent and clear the link when a bookmark is removed. - Move `ModelWithBookmark` onto MUC only. - Remove the now-vestigial setBookmarkState mixin. - Restrict the pinned list to open group chats (type + !closed) and drop dead modal imports from the shared room-item template.
Follow-up polish on the pinning code: Pin/unpin now compute the desired extensions declaratively and always (re)publish. This is idempotent and self-healing when local and server state have diverged.
jcbrand
force-pushed
the
bookmark-pinning
branch
from
June 21, 2026 20:30
e90eeb0 to
7286a84
Compare
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3949